[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20181107141428.bd1f8b1a989449633394d8c1@linux-foundation.org>
Date: Wed, 7 Nov 2018 14:14:28 -0800
From: Andrew Morton <akpm@...ux-foundation.org>
To: Alexey Skidanov <alexey.skidanov@...el.com>
Cc: sbates@...thlin.com, logang@...tatee.com, danielmentz@...gle.com,
mathieu.desnoyers@...icios.com, linux-kernel@...r.kernel.org,
labbott@...hat.com
Subject: Re: [PATCH] lib/genaloc: Fix allocation of aligned buffer from
non-aligned chunk
On Wed, 7 Nov 2018 08:21:07 +0200 Alexey Skidanov <alexey.skidanov@...el.com> wrote:
> > Why does this need "fixing"? Are there current callers which can
> > misalign chunk_start_addr? Or is there a requirement that future
> > callers can misalign chunk_start_addr?
> >
> I work on adding aligned allocation support for ION heaps
> (https://www.spinics.net/lists/linux-driver-devel/msg118754.html). Two
> of these heaps use genpool internally.
>
> If you want to have an ability to allocate buffers aligned on different
> boundaries (for example, 4K, 1MB, ...), this fix actually removes the
> requirement for chunk_start_addr to be aligned on the max possible
> alignment.
OK. This sort of information should be in the changelog, please. In
much detail.
Powered by blists - more mailing lists