linux-kernel - RE: [PATCH v2 3/4] dts/arm/ls1021a: Clean PCIe controller compatible strings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 7 Nov 2018 04:29:19 +0000
From:   "Z.q. Hou" <zhiqiang.hou@....com>
To:     Leo Li <leoyang.li@....com>
CC:     "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@...ts.infradead.org>,
        lkml <linux-kernel@...r.kernel.org>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>, Rob Herring <robh+dt@...nel.org>,
        Shawn Guo <shawnguo@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Mingkai Hu <mingkai.hu@....com>,
        "M.h. Lian" <minghuan.lian@....com>
Subject: RE: [PATCH v2 3/4] dts/arm/ls1021a: Clean PCIe controller compatible
 strings

Hi Leo,

Thanks a lot for your comments!

> -----Original Message-----
> From: Li Yang <leoyang.li@....com>
> Sent: 2018年10月27日 4:58
> To: Z.q. Hou <zhiqiang.hou@....com>
> Cc: moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
> <linux-arm-kernel@...ts.infradead.org>; lkml <linux-kernel@...r.kernel.org>;
> linux-pci@...r.kernel.org; open list:OPEN FIRMWARE AND FLATTENED
> DEVICE TREE BINDINGS <devicetree@...r.kernel.org>; Rob Herring
> <robh+dt@...nel.org>; Shawn Guo <shawnguo@...nel.org>; Mark Rutland
> <mark.rutland@....com>; Bjorn Helgaas <bhelgaas@...gle.com>; Mingkai
> Hu <mingkai.hu@....com>; M.h. Lian <minghuan.lian@....com>
> Subject: Re: [PATCH v2 3/4] dts/arm/ls1021a: Clean PCIe controller
> compatible strings
> 
> On Thu, Oct 25, 2018 at 4:52 AM Z.q. Hou <zhiqiang.hou@....com> wrote:
> 
> The correct prefix for arm dts patches should be: "ARM: dts: ls1021a:
> ...", and it should be better to mention the string removed in the title too.

Will correct it in v3.

> 
> >
> > From: Hou Zhiqiang <Zhiqiang.Hou@....com>
> >
> > Removed the wrong compatible string "snps,dw-pcie", in case match
> > incorrect driver.
> >
> > Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@....com>
> > ---
> > V2:
> >  - no change
> >
> >  arch/arm/boot/dts/ls1021a.dtsi | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/ls1021a.dtsi
> > b/arch/arm/boot/dts/ls1021a.dtsi index bdd6e66a79ad..1aaa3288a450
> > 100644
> > --- a/arch/arm/boot/dts/ls1021a.dtsi
> > +++ b/arch/arm/boot/dts/ls1021a.dtsi
> > @@ -716,7 +716,7 @@
> >                 };
> >
> >                 pcie@...0000 {
> > -                       compatible = "fsl,ls1021a-pcie",
> "snps,dw-pcie";
> > +                       compatible = "fsl,ls1021a-pcie";
> >                         reg = <0x00 0x03400000 0x0 0x00010000
> /* controller registers */
> >                                0x40 0x00000000 0x0 0x00002000>;
> /* configuration space */
> >                         reg-names = "regs", "config"; @@ -739,7
> +739,7
> > @@
> >                 };
> >
> >                 pcie@...0000 {
> > -                       compatible = "fsl,ls1021a-pcie",
> "snps,dw-pcie";
> > +                       compatible = "fsl,ls1021a-pcie";
> >                         reg = <0x00 0x03500000 0x0 0x00010000
> /* controller registers */
> >                                0x48 0x00000000 0x0 0x00002000>;
> /* configuration space */
> >                         reg-names = "regs", "config";
> > --
> > 2.17.1
> >

Thanks,
Zhiqiang