linux-kernel - [PATCHv2] PCI/Layerscape: fix wrongly invoking of outbound window disable accessor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181107051647.12242-1-Zhiqiang.Hou@nxp.com>
Date:   Wed, 7 Nov 2018 05:16:49 +0000
From:   "Z.q. Hou" <zhiqiang.hou@....com>
To:     "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "bhelgaas@...gle.com" <bhelgaas@...gle.com>,
        "lorenzo.pieralisi@....com" <lorenzo.pieralisi@....com>
CC:     Roy Zang <roy.zang@....com>, "M.h. Lian" <minghuan.lian@....com>,
        "Z.q. Hou" <zhiqiang.hou@....com>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: [PATCHv2] PCI/Layerscape: fix wrongly invoking of outbound window
 disable accessor

From: Hou Zhiqiang <Zhiqiang.Hou@....com>

The order of parameters is not correct when invoking the outbound
window disable routine.

Fixes: commit 4a2745d760fac ("PCI: layerscape: Disable outbound
windows configured by bootloader").

Cc: stable@...r.kernel.org
Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@....com>
---
V2:
 - Tagged this patch for stable.
 - Reworded the commit description.

 drivers/pci/controller/dwc/pci-layerscape.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/controller/dwc/pci-layerscape.c b/drivers/pci/controller/dwc/pci-layerscape.c
index 3724d3ef7008..7aa9a82b7ebd 100644
--- a/drivers/pci/controller/dwc/pci-layerscape.c
+++ b/drivers/pci/controller/dwc/pci-layerscape.c
@@ -88,7 +88,7 @@ static void ls_pcie_disable_outbound_atus(struct ls_pcie *pcie)
 	int i;
 
 	for (i = 0; i < PCIE_IATU_NUM; i++)
-		dw_pcie_disable_atu(pcie->pci, DW_PCIE_REGION_OUTBOUND, i);
+		dw_pcie_disable_atu(pcie->pci, i, DW_PCIE_REGION_OUTBOUND);
 }
 
 static int ls1021_pcie_link_up(struct dw_pcie *pci)
-- 
2.17.1