[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1541577326.3089.2.camel@suse.de>
Date: Wed, 07 Nov 2018 08:55:26 +0100
From: osalvador <osalvador@...e.de>
To: Michal Hocko <mhocko@...nel.org>,
Balbir Singh <bsingharora@...il.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
Baoquan He <bhe@...hat.com>, linux-mm@...ck.org,
LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mm, memory_hotplug: check zone_movable in
has_unmovable_pages
On Wed, 2018-11-07 at 08:35 +0100, Michal Hocko wrote:
> On Wed 07-11-18 07:35:18, Balbir Singh wrote:
> > The check seems to be quite aggressive and in a loop that iterates
> > pages, but has nothing to do with the page, did you mean to make
> > the check
> >
> > zone_idx(page_zone(page)) == ZONE_MOVABLE
>
> Does it make any difference? Can we actually encounter a page from a
> different zone here?
AFAIK, test_pages_in_a_zone() called from offline_pages() should ensure
that the range belongs to a unique zone, so we should not encounter
pages from other zones there, right?
---
Oscar
Suse L3
Powered by blists - more mailing lists