linux-kernel - Re: [PATCH v2 3/4] mm: convert totalram_pages and totalhigh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5edc432c-b475-5d2e-6a87-700c32a8fad9@suse.cz>
Date:   Wed, 7 Nov 2018 10:04:59 +0100
From:   Vlastimil Babka <vbabka@...e.cz>
To:     Arun KS <arunks@...eaurora.org>, akpm@...ux-foundation.org,
        keescook@...omium.org, khlebnikov@...dex-team.ru,
        minchan@...nel.org, mhocko@...nel.org, osalvador@...e.de,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org
Cc:     getarunks@...il.com
Subject: Re: [PATCH v2 3/4] mm: convert totalram_pages and totalhigh_pages
 variables to atomic

On 11/6/18 5:21 PM, Arun KS wrote:
> totalram_pages and totalhigh_pages are made static inline function.
> 
> Suggested-by: Michal Hocko <mhocko@...e.com>
> Suggested-by: Vlastimil Babka <vbabka@...e.cz>
> Signed-off-by: Arun KS <arunks@...eaurora.org>
> Reviewed-by: Konstantin Khlebnikov <khlebnikov@...dex-team.ru>
> Acked-by: Michal Hocko <mhocko@...e.com>

Acked-by: Vlastimil Babka <vbabka@...e.cz>

One bug (probably) below:

> diff --git a/mm/highmem.c b/mm/highmem.c
> index 59db322..02a9a4b 100644
> --- a/mm/highmem.c
> +++ b/mm/highmem.c
> @@ -105,9 +105,7 @@ static inline wait_queue_head_t *get_pkmap_wait_queue_head(unsigned int color)
>  }
>  #endif
>  
> -unsigned long totalhigh_pages __read_mostly;
> -EXPORT_SYMBOL(totalhigh_pages);

I think you still need to export _totalhigh_pages so that modules can
use the inline accessors.

> -
> +atomic_long_t _totalhigh_pages __read_mostly;
>  
>  EXPORT_PER_CPU_SYMBOL(__kmap_atomic_idx);
>