linux-kernel - [PATCH] perf script: add newline after uregs output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20181107093705.16346-1-milian.wolff@kdab.com>
Date:   Wed,  7 Nov 2018 10:37:05 +0100
From:   Milian Wolff <milian.wolff@...b.com>
To:     acme@...nel.org, jolsa@...nel.org
Cc:     Linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org,
        Milian Wolff <milian.wolff@...b.com>
Subject: [PATCH] perf script: add newline after uregs output

This change makes it much easier to easily distinguish
between consecutive samples by keeping the empty line
between them, like we see when we do not enable uregs
output.

Before:

```
cpp-inlining 28298 [-01] 54837.342780:    3068085 cycles:pp:
            7ffff7c96709 __hypot_finite+0xa9 (/usr/lib/libm-2.28.so)
            ...
 ABI:2    AX:0x0    BX:0x40f56cf6    CX:0x294a3ae7    ...
cpp-inlining 28298 [-01] 54837.344493:    2881929 cycles:pp:
            7ffff7c96696 __hypot_finite+0x36 (/usr/lib/libm-2.28.so)
            ...
 ABI:2    AX:0x40d440c7    BX:0x40d440c7    CX:0x4d45e5da    ...
```

After:

```
cpp-inlining 28298 [-01] 54837.342780:    3068085 cycles:pp:
            7ffff7c96709 __hypot_finite+0xa9 (/usr/lib/libm-2.28.so)
            ...
 ABI:2    AX:0x0    BX:0x40f56cf6    CX:0x294a3ae7    ...

cpp-inlining 28298 [-01] 54837.344493:    2881929 cycles:pp:
            7ffff7c96696 __hypot_finite+0x36 (/usr/lib/libm-2.28.so)
            ...
 ABI:2    AX:0x40d440c7    BX:0x40d440c7    CX:0x4d45e5da    ...
```

Signed-off-by: Milian Wolff <milian.wolff@...b.com>
Cc: Arnaldo Carvalho de Melo <acme@...nel.org>
---
 tools/perf/builtin-script.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
index b5bc85bd0bbe..daf73832743e 100644
--- a/tools/perf/builtin-script.c
+++ b/tools/perf/builtin-script.c
@@ -603,6 +603,8 @@ static int perf_sample__fprintf_uregs(struct perf_sample *sample,
 		printed += fprintf(fp, "%5s:0x%"PRIx64" ", perf_reg_name(r), val);
 	}
 
+	fprintf(fp, "\n");
+
 	return printed;
 }
 
-- 
2.19.1