[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20181107140601.53y5vlubtugeczyt@pathway.suse.cz>
Date: Wed, 7 Nov 2018 15:06:01 +0100
From: Petr Mladek <pmladek@...e.com>
To: Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>,
Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
Dmitriy Vyukov <dvyukov@...gle.com>,
Steven Rostedt <rostedt@...dmis.org>,
Alexander Potapenko <glider@...gle.com>,
Fengguang Wu <fengguang.wu@...el.com>,
Josh Poimboeuf <jpoimboe@...hat.com>,
LKML <linux-kernel@...r.kernel.org>,
Linus Torvalds <torvalds@...ux-foundation.org>,
Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org,
Ingo Molnar <mingo@...hat.com>,
Peter Zijlstra <peterz@...radead.org>,
Will Deacon <will.deacon@....com>
Subject: Re: [PATCH v6 1/3] printk: Add line-buffered printk() API.
On Fri 2018-11-02 22:31:55, Tetsuo Handa wrote:
> How to use this API:
>
> (1) Call get_printk_buffer() and acquire "struct printk_buffer *".
>
> (2) Rewrite printk() calls in the following way. The "ptr" is
> "struct printk_buffer *" obtained in step (1).
>
> printk(fmt, ...) => printk_buffered(ptr, fmt, ...)
> vprintk(fmt, args) => vprintk_buffered(ptr, fmt, args)
> pr_emerg(fmt, ...) => bpr_emerg(ptr, fmt, ...)
> pr_alert(fmt, ...) => bpr_alert(ptr, fmt, ...)
> pr_crit(fmt, ...) => bpr_crit(ptr, fmt, ...)
> pr_err(fmt, ...) => bpr_err(ptr, fmt, ...)
> pr_warning(fmt, ...) => bpr_warning(ptr, fmt, ...)
> pr_warn(fmt, ...) => bpr_warn(ptr, fmt, ...)
> pr_notice(fmt, ...) => bpr_notice(ptr, fmt, ...)
> pr_info(fmt, ...) => bpr_info(ptr, fmt, ...)
> pr_cont(fmt, ...) => bpr_cont(ptr, fmt, ...)
I am looking at the sample conversions. We actually won't need
bpr_cont(). We will use buffer_printk() instead.
Well, I think about renaming buffer_printk() to bprintk() or
define it as a wrapper at least.
Best Regards,
Petr
Powered by blists - more mailing lists