linux-kernel - Re: [PATCH v2] slimbus: ngd: QCOM_QMI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f6e9ae15-b52b-b8c5-3d16-3b67b8977c38@linaro.org>
Date:   Wed, 7 Nov 2018 14:15:33 +0000
From:   Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:     Greg KH <gregkh@...uxfoundation.org>,
        Niklas Cassel <niklas.cassel@...aro.org>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] slimbus: ngd: QCOM_QMI_HELPERS has to be selected



On 07/11/18 13:59, Greg KH wrote:
> Really?  I do this and then I get this build error on x86:
> 
> drivers/slimbus/qcom-ngd-ctrl.c: In function ‘of_qcom_slim_ngd_register’:
> drivers/slimbus/qcom-ngd-ctrl.c:1333:63: warning: dereferencing ‘void *’ pointer
>    data = of_match_node(qcom_slim_ngd_dt_match, parent->of_node)->data;
>                                                                 ^~
> drivers/slimbus/qcom-ngd-ctrl.c:1333:63: error: request for member ‘data’ in something not a structure or union
> 
> 
> So I can't take this, something else must be wrong here...
That is fine!
Yes, there seems to be one more issue here, on non DT platforms 
of_match_node is set to be NULL, which is why we are seeing this error I 
guess!

I will fix this up, do some test and send both the fixes together.

thanks,
srini