[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <a2fabbe4-a3be-6d10-1634-a5b23036c6f0@bristot.me>
Date: Wed, 7 Nov 2018 15:17:36 +0100
From: Daniel Bristot de Oliveira <daniel@...stot.me>
To: Juri Lelli <juri.lelli@...hat.com>, peterz@...radead.org,
mingo@...hat.com
Cc: rostedt@...dmis.org, tglx@...utronix.de,
linux-kernel@...r.kernel.org, luca.abeni@...tannapisa.it,
claudio@...dence.eu.com, bristot@...hat.com,
linux-rt-users@...r.kernel.org, mtk.manpages@...il.com,
Mathieu Poirier <mathieu.poirier@...aro.org>
Subject: Re: [PATCH] kernel/time/posix-cpu-timers: Remove useless call to
check_dl_overrun
On 11/7/18 12:10 PM, Juri Lelli wrote:
> check_dl_overrun is used to send a SIGXCPU to users that asked to be
> informed when SCHED_DEADLINE runtime overruns occur.
>
> The function is called by check_thread_timers already, so the call in
> check_process_timers is redundant/wrong (even though harmless).
>
> Remove it.
>
> Fixes: 34be39305a77 ("sched/deadline: Implement "runtime overrun signal" support")
> Signed-off-by: Juri Lelli <juri.lelli@...hat.com>
> Cc: Peter Zijlstra <peterz@...radead.org>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Luca Abeni <luca.abeni@...tannapisa.it>
> Cc: Claudio Scordino <claudio@...dence.eu.com>
> Cc: Mathieu Poirier <mathieu.poirier@...aro.org>
Reviewed-by: Daniel Bristot de Oliveira <bristot@...hat.com>
Thanks!
-- Daniel
> ---
> kernel/time/posix-cpu-timers.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/kernel/time/posix-cpu-timers.c b/kernel/time/posix-cpu-timers.c
> index ce32cf741b25..8f0644af40be 100644
> --- a/kernel/time/posix-cpu-timers.c
> +++ b/kernel/time/posix-cpu-timers.c
> @@ -917,9 +917,6 @@ static void check_process_timers(struct task_struct *tsk,
> struct task_cputime cputime;
> unsigned long soft;
>
> - if (dl_task(tsk))
> - check_dl_overrun(tsk);
> -
> /*
> * If cputimer is not running, then there are no active
> * process wide timers (POSIX 1.b, itimers, RLIMIT_CPU).
>
Powered by blists - more mailing lists