linux-kernel - Re: [PATCH] Make JFFS2 endianness configurable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <08C13A64-E842-4E4D-AD04-31C09DFD1108@cisco.com>
Date:   Wed, 7 Nov 2018 01:09:29 +0000
From:   "Nikunj Kela (nkela)" <nkela@...co.com>
To:     Richard Weinberger <richard@....at>,
        "Daniel Walker (danielwa)" <danielwa@...co.com>
CC:     Richard Weinberger <richard.weinberger@...il.com>,
        Al Viro <viro@...iv.linux.org.uk>,
        "xe-linux-external(mailer list)" <xe-linux-external@...co.com>,
        LKML <linux-kernel@...r.kernel.org>,
        "linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>,
        Rod Whitby <rod@...tby.id.au>,
        David Woodhouse <dwmw2@...radead.org>
Subject: Re: [PATCH] Make JFFS2 endianness configurable

Thanks for input. I have posted another patch with mount option:

http://lists.infradead.org/pipermail/linux-mtd/2018-November/085252.html


On 11/2/18, 2:23 PM, "Richard Weinberger" <richard@....at> wrote:

    Am Freitag, 2. November 2018, 22:14:44 CET schrieb Daniel Walker:
    > > Make it a mount option and store the endianness mode in the super block.
    > 
    > It's actually a mkfs option currently. I'm not sure how that factors in,
    > 
    > from the mkfs.jffs2 man page,
    > 
    >        -l, --little-endian
    >               Create a little-endian JFFS2 image.  Default is to make an image with the same endianness as the host.
    > 
    >        -b, --big-endian
    >               Create a big-endian JFFS2 image.  Default is to make an image with the same endianness as the host.
    
    As long this setting is not stored in the filesystem itself, it is useless.
    IIRC it just controls the endianness setting for mkfs.jffs2's
    t32() and t16() macros.
    
    That's why I think of a mount option like "force_endian=".
    
    Thanks,
    //richard