linux-kernel - Re: [PATCH 1/3] i3c: master: Add driver for Synopsys DesignWare IP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181107173741.GL3074@bombadil.infradead.org>
Date:   Wed, 7 Nov 2018 09:37:41 -0800
From:   Matthew Wilcox <willy@...radead.org>
To:     vitor <vitor.soares@...opsys.com>
Cc:     boris.brezillon@...tlin.com, wsa@...-dreams.de,
        linux-i2c@...r.kernel.org, corbet@....net,
        linux-doc@...r.kernel.org, gregkh@...uxfoundation.org,
        arnd@...db.de, psroka@...ence.com, agolec@...ence.com,
        adouglas@...ence.com, bfolta@...ence.com, dkos@...ence.com,
        alicja@...ence.com, cwronka@...ence.com, sureshp@...ence.com,
        rafalc@...ence.com, thomas.petazzoni@...tlin.com, nm@...com,
        robh+dt@...nel.org, pawel.moll@....com, mark.rutland@....com,
        ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        geert@...ux-m68k.org, linus.walleij@...aro.org,
        Xiang.Lin@...aptics.com, linux-gpio@...r.kernel.org,
        nsekhar@...com, pgaj@...ence.com, peda@...ntia.se,
        mshettel@...eaurora.org, swboyd@...omium.org,
        joao.pinto@...opsys.com, luis.oliveira@...opsys.com,
        manuel.abreu@...opsys.com, gustavo.pimentel@...opsys.com
Subject: Re: [PATCH 1/3] i3c: master: Add driver for Synopsys DesignWare IP

On Wed, Nov 07, 2018 at 05:30:22PM +0000, vitor wrote:
> Hi Matthew,
> 
> 
> On 07/11/18 17:05, Matthew Wilcox wrote:
> > On Mon, Oct 29, 2018 at 10:06:56AM +0000, Vitor soares wrote:
> > > Add driver for Synopsys DesignWare I3C master IP
> > The so-called "data sheet" (actually just an advertising brochure)
> 
> The datasheet is there to download.

Really?  I went to the link in your message, filled out the stupid
information box that your company has now decided to start spamming
me with, and I got a 2-page brochure telling me how wonderful it was.
It's *called* a datasheet.  Even right there in its name: dwc_mipi_i3c_ds.pdf
It's not a data sheet.

> Right now the driver does not support DMA interface which will be added
> later as the other missed I3C features.
> 
> What do you suggest to avoid this misunderstanding?

A big missing feature like that is probably worth mentioning in a comment.
eg: TODO: DMA support.