linux-kernel - Re: [PATCH] dt-bindings: hwmon: tmp108: add optional interrupts and #thermal-sensor-cells

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181107183958.GB5468@roeck-us.net>
Date:   Wed, 7 Nov 2018 10:39:58 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Heiko Stuebner <heiko@...ech.de>
Cc:     jdelvare@...e.com, robh+dt@...nel.org, mark.rutland@....com,
        linux-hwmon@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Heiko Stuebner <heiko.stuebner@...com>
Subject: Re: [PATCH] dt-bindings: hwmon: tmp108: add optional interrupts and
 #thermal-sensor-cells

Hi,

On Wed, Nov 07, 2018 at 04:47:08PM +0100, Heiko Stuebner wrote:
> From: Heiko Stuebner <heiko.stuebner@...com>
> 
> The tmp108 does have an alert output that can be used as interrupt source
> and can of course also be used as part of a thermal sensor setup for things
> like thermal-based cpu frequencies, so document the necessary properties.
> 
> Signed-off-by: Heiko Stuebner <heiko.stuebner@...com>

Do you also plan to actually implement interrupt support in the driver ?

Guenter

> ---
>  Documentation/devicetree/bindings/hwmon/tmp108.txt | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/tmp108.txt b/Documentation/devicetree/bindings/hwmon/tmp108.txt
> index 8c4b10df86d9..54d4beed4ee5 100644
> --- a/Documentation/devicetree/bindings/hwmon/tmp108.txt
> +++ b/Documentation/devicetree/bindings/hwmon/tmp108.txt
> @@ -7,6 +7,10 @@ Requires node properties:
>  - compatible : "ti,tmp108"
>  - reg : the I2C address of the device. This is 0x48, 0x49, 0x4a, or 0x4b.
>  
> +Optional properties:
> +- interrupts: Reference to the TMP108 alert interrupt.
> +- #thermal-sensor-cells: should be set to 0.
> +
>  Example:
>  	tmp108@48 {
>  		compatible = "ti,tmp108";
> -- 
> 2.18.0
>