linux-kernel - Re: [PATCH v2 -next] edac: i82975x: remove set but not used variable 'dtype'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181107192340.GE14169@zn.tnic>
Date:   Wed, 7 Nov 2018 20:23:40 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     linux-edac@...r.kernel.org, ravi@...ztechnologies.com,
        arvino55@...il.com, mchehab@...nel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 -next] edac: i82975x: remove set but not used variable
 'dtype'

On Wed, Nov 07, 2018 at 10:22:37AM +0800, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/edac/i82975x_edac.c:378:16: warning:
>  variable 'dtype' set but not used [-Wunused-but-set-variable]
> 
> It never used since introduction in commit
> 084a4fccef39 ("edac: move dimm properties to struct dimm_info")
> 
> Also remove function i82975x_dram_type and move the comment and the
> assignment to the single called place.
> 
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
> v2: remove unnecessary function i82975x_dram_type
> ---
>  drivers/edac/i82975x_edac.c | 15 ++++-----------
>  1 file changed, 4 insertions(+), 11 deletions(-)

Applied, thanks.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.