[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20181107.210731.330601031@genki.is>
Date: Wed, 07 Nov 2018 13:07:31 -0800
From: Genki Sky <sky@...ki.is>
To: Guenter Roeck <linux@...ck-us.net>
Cc: Brian Norris <briannorris@...omium.org>, lists@...dbynature.de,
yamada.masahiro@...ionext.com,
Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Revert "scripts/setlocalversion: git: Make -dirty check
more robust"
On Wed, 7 Nov 2018 12:55:14 -0800, Guenter Roeck <linux@...ck-us.net> wrote:
> I do not think it is a good idea to create a random file in the .git directory
> under any circumstance, and much less so if an output directory was specified,
> no matter if the path is read-only or not. I also still think that it is a
> bad idea to touch the source tree if an output directory was specified.
> It defeats the purpose of specifying an output directory.
I was thinking of touching a pre-existing file like .git/config or
.git/description, which I was hoping would be harmless. But sounds
like that's still not desired?
Okay, I guess one approach is to only refresh the index if $objtree ==
$srctree, by passing some flag to scripts/setlocalversion from
scripts/package/Makefile. Is that what you're thinking? Feels a little
strange, but it seems it'd satisfy everyone.
> Ubuntu 16.04 ships with git version 2.7.4.
Okay. I guess --no-optional-locks is a no-go then.
Powered by blists - more mailing lists