linux-kernel - RE: [PATCH -next] drm/ttm: remove set but not used variable 'driver'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BY2PR12MB0040B73B02AD39434F410677ECC50@BY2PR12MB0040.namprd12.prod.outlook.com>
Date:   Thu, 8 Nov 2018 06:11:51 +0000
From:   "Huang, Ray" <Ray.Huang@....com>
To:     YueHaibing <yuehaibing@...wei.com>,
        "Koenig, Christian" <Christian.Koenig@....com>,
        "Zhang, Jerry" <Jerry.Zhang@....com>,
        David Airlie <airlied@...ux.ie>
CC:     "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: RE: [PATCH -next] drm/ttm: remove set but not used variable 'driver'

> -----Original Message-----
> From: YueHaibing [mailto:yuehaibing@...wei.com]
> Sent: Thursday, November 08, 2018 10:15 AM
> To: Koenig, Christian <Christian.Koenig@....com>; Huang, Ray
> <Ray.Huang@....com>; Zhang, Jerry <Jerry.Zhang@....com>; David Airlie
> <airlied@...ux.ie>
> Cc: YueHaibing <yuehaibing@...wei.com>; dri-devel@...ts.freedesktop.org;
> linux-kernel@...r.kernel.org; kernel-janitors@...r.kernel.org
> Subject: [PATCH -next] drm/ttm: remove set but not used variable 'driver'
> 
> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/gpu/drm/ttm/ttm_execbuf_util.c: In function
> 'ttm_eu_fence_buffer_objects':
> drivers/gpu/drm/ttm/ttm_execbuf_util.c:190:24: warning:
>  variable 'driver' set but not used [-Wunused-but-set-variable]
> 
> It not used any more after
> commit f2c24b83ae90 ("drm/ttm: flip the switch, and convert to dma_fence")
> 
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Acked-by: Huang Rui <ray.huang@....com>

> ---
>  drivers/gpu/drm/ttm/ttm_execbuf_util.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/ttm/ttm_execbuf_util.c
> b/drivers/gpu/drm/ttm/ttm_execbuf_util.c
> index e493edb..efa005a 100644
> --- a/drivers/gpu/drm/ttm/ttm_execbuf_util.c
> +++ b/drivers/gpu/drm/ttm/ttm_execbuf_util.c
> @@ -187,14 +187,12 @@ void ttm_eu_fence_buffer_objects(struct
> ww_acquire_ctx *ticket,
>  	struct ttm_buffer_object *bo;
>  	struct ttm_bo_global *glob;
>  	struct ttm_bo_device *bdev;
> -	struct ttm_bo_driver *driver;
> 
>  	if (list_empty(list))
>  		return;
> 
>  	bo = list_first_entry(list, struct ttm_validate_buffer, head)->bo;
>  	bdev = bo->bdev;
> -	driver = bdev->driver;
>  	glob = bo->bdev->glob;
> 
>  	spin_lock(&glob->lru_lock);
> 
>