linux-kernel - Re: [PATCH V2] binder: ipc namespace support for android binder

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181108062143.7web34burq62gefu@linux-r8p5>
Date:   Wed, 7 Nov 2018 22:21:43 -0800
From:   Davidlohr Bueso <dave@...olabs.net>
To:     "chouryzhou(??????)" <chouryzhou@...cent.com>
Cc:     "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "arve@...roid.com" <arve@...roid.com>,
        "tkjos@...roid.com" <tkjos@...roid.com>,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V2] binder: ipc namespace support for android binder

On Mon, 29 Oct 2018, chouryzhou(??????) wrote:

>+// If init_ipc_ns is not defined elsewhere,
>+// we make a fake one here to put our variable.

/*
 * comments like this please
 */

>+#if !defined(CONFIG_SYSVIPC) &&  !defined(CONFIG_POSIX_MQUEUE)
>+struct ipc_namespace init_ipc_ns;
...
>--- a/include/linux/ipc_namespace.h
>+++ b/include/linux/ipc_namespace.h
>@@ -63,6 +63,12 @@ struct ipc_namespace {
>        unsigned int    mq_msg_default;
>        unsigned int    mq_msgsize_default;
>
>+       /* next fields are for binder */
>+       struct mutex      binder_procs_lock;
>+       struct hlist_head binder_procs;
>+       struct mutex      binder_contexts_lock;
>+       struct hlist_head binder_contexts;

Please make the above inside #ifdef CONFIG_ANDROID_BINDER_IPC.

Thanks,
Davidlohr