linux-kernel - Re: [driver-core PATCH v6 3/9] device core: Consolidate locking and unlocking of parent and device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b92d7ea58dafefc30128dacebc6de6fb9c7fa8e8.camel@linux.intel.com>
Date:   Thu, 08 Nov 2018 14:48:59 -0800
From:   Alexander Duyck <alexander.h.duyck@...ux.intel.com>
To:     jane.chu@...cle.com, linux-kernel@...r.kernel.org,
        gregkh@...uxfoundation.org
Cc:     len.brown@...el.com, bvanassche@....org, linux-pm@...r.kernel.org,
        rafael@...nel.org, jiangshanlai@...il.com,
        linux-nvdimm@...ts.01.org, pavel@....cz, zwisler@...nel.org,
        tj@...nel.org, akpm@...ux-foundation.org
Subject: Re: [driver-core PATCH v6 3/9] device core: Consolidate locking and
 unlocking of parent and device

On Thu, 2018-11-08 at 14:43 -0800, jane.chu@...cle.com wrote:
> Hi, Alex,
> 
> 
> On 11/08/2018 10:06 AM, Alexander Duyck wrote:
> > +/*
> > + * __device_driver_lock - release locks needed to manipulate dev->drv
> 
> You meant to say __device_driver_unlock, right?

Yes, you are correct.

> > + * @dev: Device we will update driver info for
> > + * @parent: Parent device. Needed if the bus requires parent lock
> > + *
> > + * This function will release the required locks for manipulating dev->drv.
> > + * Normally this will just be the the @dev lock, but when called for a
> > + * USB interface, @parent lock will be released as well.
> > + */
> > +static void __device_driver_unlock(struct device *dev, struct device *parent)
> > +{
> > +	device_unlock(dev);
> > +	if (parent && dev->bus->need_parent_lock)
> > +		device_unlock(parent);
> > +}
> 
> -jane

Thanks.

- Alex