lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 08 Nov 2018 11:05:16 +1030 From: Andrew Jeffery <andrew@...id.au> To: Julia Lawall <Julia.Lawall@...6.fr>, Felipe Balbi <balbi@...nel.org> Cc: kernel-janitors@...r.kernel.org, "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>, Joel Stanley <joel@....id.au>, linux-usb@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-aspeed@...ts.ozlabs.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] usb: gadget: aspeed-vhub: constify usb_gadget_ops structure On Wed, 31 Oct 2018, at 02:49, Julia Lawall wrote: > The usb_gadget_ops structure can be const as it is only stored in > the ops field of a usb_gadget structure and this field is const. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr> Reviewed-by: Andrew Jeffery <andrew@...id.au> > > --- > drivers/usb/gadget/udc/aspeed-vhub/dev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/gadget/udc/aspeed-vhub/dev.c b/drivers/usb/ > gadget/udc/aspeed-vhub/dev.c > index f0233912bace..6b1b16b17d7d 100644 > --- a/drivers/usb/gadget/udc/aspeed-vhub/dev.c > +++ b/drivers/usb/gadget/udc/aspeed-vhub/dev.c > @@ -438,7 +438,7 @@ static int ast_vhub_udc_stop(struct usb_gadget > *gadget) > return 0; > } > > -static struct usb_gadget_ops ast_vhub_udc_ops = { > +static const struct usb_gadget_ops ast_vhub_udc_ops = { > .get_frame = ast_vhub_udc_get_frame, > .wakeup = ast_vhub_udc_wakeup, > .pullup = ast_vhub_udc_pullup, >
Powered by blists - more mailing lists