linux-kernel - Re: [PATCH][i3c-next] i3c: fix incorrect update to max_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <38ffc3d2-4390-29df-203a-58fbe04fdc81@canonical.com>
Date:   Thu, 8 Nov 2018 09:10:44 +0000
From:   Colin Ian King <colin.king@...onical.com>
To:     Boris Brezillon <boris.brezillon@...tlin.com>
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][i3c-next] i3c: fix incorrect update to max_read_ds

On 08/11/2018 09:09, Boris Brezillon wrote:
> On Wed,  7 Nov 2018 20:42:08 +0000
> Hi Colin,
> 
> Colin King <colin.king@...onical.com> wrote:
> 
>> From: Colin Ian King <colin.king@...onical.com>
>>
>> Currently max_read_ds is being updated twice, which is incorrect.
>> The second assignment should be to max_write_ds instead. Fix this.
>>
>> Detected by CoverityScan, CID#1475379 ("Unused value")
>>
>> Fixes: 50cacdabeae1 ("i3c: Add core I3C infrastructure")
>> Signed-off-by: Colin Ian King <colin.king@...onical.com>
>> ---
>>  drivers/i3c/master.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c
>> index 68d6553dbd75..0ea7bb045fad 100644
>> --- a/drivers/i3c/master.c
>> +++ b/drivers/i3c/master.c
>> @@ -1093,7 +1093,7 @@ static int i3c_master_getmxds_locked(struct i3c_master_controller *master,
>>  	}
>>  
>>  	info->max_read_ds = getmaxds->maxrd;
>> -	info->max_read_ds = getmaxds->maxwr;
>> +	info->max_write_ds = getmaxds->maxwr;
> 
> Thanks for the fix.
> 
> Since the I3C driver is not merged yet, would you mind if I squash your
> changes in the commit introducing the bug?

Sure, that's fine with me.

Colin
> 
> Regards,
> 
> Boris
>