linux-kernel - Re: [PATCH v1 5/5] media: venus: update number of bytes used field properly for EOS frames

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 8 Nov 2018 12:16:10 +0200
From:   Stanimir Varbanov <stanimir.varbanov@...aro.org>
To:     Srinu Gorle <sgorle@...eaurora.org>, hverkuil@...all.nl,
        mchehab@...nel.org, linux-media@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org
Cc:     acourbot@...omium.org, vgarodia@...eaurora.org
Subject: Re: [PATCH v1 5/5] media: venus: update number of bytes used field
 properly for EOS frames

Hi,

On 9/29/18 3:00 PM, Srinu Gorle wrote:
> - In video decoder session, update number of bytes used for
>   yuv buffers appropriately for EOS buffers.
> 
> Signed-off-by: Srinu Gorle <sgorle@...eaurora.org>
> ---
>  drivers/media/platform/qcom/venus/vdec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

NACK, that was already discussed see:

https://patchwork.kernel.org/patch/10630411/

> 
> diff --git a/drivers/media/platform/qcom/venus/vdec.c b/drivers/media/platform/qcom/venus/vdec.c
> index 311f209..a48eed1 100644
> --- a/drivers/media/platform/qcom/venus/vdec.c
> +++ b/drivers/media/platform/qcom/venus/vdec.c
> @@ -978,7 +978,7 @@ static void vdec_buf_done(struct venus_inst *inst, unsigned int buf_type,
>  
>  		if (vbuf->flags & V4L2_BUF_FLAG_LAST) {
>  			const struct v4l2_event ev = { .type = V4L2_EVENT_EOS };
> -
> +			vb->planes[0].bytesused = bytesused;
>  			v4l2_event_queue_fh(&inst->fh, &ev);
>  		}
>  	} else {
> 

-- 
regards,
Stan