linux-kernel - Re: [PATCH v3 1/4] mm: reference totalram_pages and managed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bceb1841-885f-a35a-b4a0-522f588af956@suse.cz>
Date:   Thu, 8 Nov 2018 12:44:53 +0100
From:   Vlastimil Babka <vbabka@...e.cz>
To:     Arun KS <arunks@...eaurora.org>, akpm@...ux-foundation.org,
        keescook@...omium.org, khlebnikov@...dex-team.ru,
        minchan@...nel.org, mhocko@...nel.org, osalvador@...e.de,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org
Cc:     getarunks@...il.com
Subject: Re: [PATCH v3 1/4] mm: reference totalram_pages and managed_pages
 once per function

On 11/8/18 9:23 AM, Arun KS wrote:
> This patch is in preparation to a later patch which converts totalram_pages
> and zone->managed_pages to atomic variables. Please note that re-reading
> the value might lead to a different value and as such it could lead to
> unexpected behavior. There are no known bugs as a result of the current code
> but it is better to prevent from them in principle.

..., which will happen after the atomic conversion in the next patch.

> Signed-off-by: Arun KS <arunks@...eaurora.org>
> Reviewed-by: Konstantin Khlebnikov <khlebnikov@...dex-team.ru>
> Acked-by: Michal Hocko <mhocko@...e.com>

Acked-by: Vlastimil Babka <vbabka@...e.cz>