linux-kernel - Re: [PATCH RESEND] arm64: dts: meson-axg: fix dtc warning about unit address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 8 Nov 2018 14:28:22 +0100
From:   Neil Armstrong <narmstrong@...libre.com>
To:     Jerome Brunet <jbrunet@...libre.com>,
        Kevin Hilman <khilman@...libre.com>,
        Carlo Caione <carlo@...one.org>
Cc:     devicetree@...r.kernel.org,
        Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        linux-kernel@...r.kernel.org, linux-amlogic@...ts.infradead.org,
        Fabio Estevam <festevam@...il.com>
Subject: Re: [PATCH RESEND] arm64: dts: meson-axg: fix dtc warning about unit
 address

On 08/11/2018 10:51, Jerome Brunet wrote:
> section 2.2.1 of the DT specs says: " If the node has no reg property,
> the @unit-address must be omitted and the node-name alone differentiates
> the node from other nodes at the same level in the tree"
> 
> Simply replace the '@' with a '-' to fix this warning.
> 
> Cc: Fabio Estevam <festevam@...il.com>
> Cc: Martin Blumenstingl <martin.blumenstingl@...glemail.com>
> Signed-off-by: Jerome Brunet <jbrunet@...libre.com>
> ---
> 
> Hi Kevin,
> 
> I'm resending this change because I noticed the previous patch I sent had
> references to spdif input which has not been merged yet. This would have
> triggered a conflict in your tree.
> 
> Hopefully, this new version will apply correctly
> 
> Cheers
> Jerome
> 
>  .../arm64/boot/dts/amlogic/meson-axg-s400.dts | 26 +++++++++----------
>  arch/arm64/boot/dts/amlogic/meson-axg.dtsi    |  6 ++---
>  2 files changed, 16 insertions(+), 16 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts b/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts
> index 18778ada7bd3..ba44b0419404 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts
> @@ -60,7 +60,7 @@
>  		serial1 = &uart_A;
>  	};
>  

[...]

>  
> -	tdmif_c: audio-controller@2 {
> +	tdmif_c: audio-controller-2 {
>  		compatible = "amlogic,axg-tdm-iface";
>  		#sound-dai-cells = <0>;
>  		sound-name-prefix = "TDM_C";
> 

Reviewed-by: Neil Armstrong <narmstrong@...libre.com>