linux-kernel - RE: [PATCH V2] binder: ipc namespace support for android binder

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <5FBCBE569E134E4CA167B91C0A77FD610198F8406F@EXMBX-SZMAIL022.tencent.com>
Date:   Thu, 8 Nov 2018 03:01:15 +0000
From:   chouryzhou(周威) <chouryzhou@...cent.com>
To:     Andrew Morton <akpm@...ux-foundation.org>
CC:     "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "arve@...roid.com" <arve@...roid.com>,
        "tkjos@...roid.com" <tkjos@...roid.com>,
        "dave@...olabs.net" <dave@...olabs.net>,
        "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        chouryzhou(周威) <chouryzhou@...cent.com>
Subject: RE: [PATCH V2] binder: ipc namespace support for android binder

> -----Original Message-----
> From: Andrew Morton <akpm@...ux-foundation.org>
> Sent: Thursday, November 8, 2018 6:38 AM
> To: chouryzhou(周威) <chouryzhou@...cent.com>
> Cc: gregkh@...uxfoundation.org; arve@...roid.com; tkjos@...roid.com;
> dave@...olabs.net; devel@...verdev.osuosl.org; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH V2] binder: ipc namespace support for android
> binder
> 
> On Wed, 7 Nov 2018 01:48:12 +0000 chouryzhou(周威)
> <chouryzhou@...cent.com> wrote:
> 
> > > > --- a/ipc/namespace.c
> > > > +++ b/ipc/namespace.c
> > > > @@ -56,6 +56,9 @@ static struct ipc_namespace *create_ipc_ns(struct
> > > user_namespace *user_ns,
> > > >         ns->ucounts = ucounts;
> > > >
> > > >         err = mq_init_ns(ns);
> > > > +       if (err)
> > > > +               goto fail_put;
> > > > +       err = binder_init_ns(ns);
> > > >         if (err)
> > > >                 goto fail_put;
> > > >
> > >
> > > Don't we need an mq_put_mnt() if binder_init_ns() fails?
> > >
> > > free_ipc_ns() seems to have forgotten about that too.  In which case it
> > > must be madly leaking mounts so probably I'm wrong.  Confused.
> > >
> >
> > mq_init_ns will do clean job if it failed, and as do binder_init_ns.
> 
> My point is that if mq_init_ns() succeeds and binder_init_ns() fails,
> we don't undo the effects of mq_init_ns()?

Oh, mq_put_mnt is called in put_ipc_ns. We should invoke put_ipc_ns if binder_init_ns fails. I will update the patch soon. Thank you very much for pointing out the issue.