linux-kernel - Re: [PATCH -next] drm/radeon: remove set but not used variable 'rdev'

Open Source and information security mailing list archives

Message-ID: <CADnq5_NrRBH_2jNqJq-vQoSraPNvfihFDuyLTK3erR_W=qyUzw@mail.gmail.com>
Date:   Thu, 8 Nov 2018 15:33:26 -0500
From:   Alex Deucher <alexdeucher@...il.com>
To:     yuehaibing@...wei.com
Cc:     "Deucher, Alexander" <alexander.deucher@....com>,
        Christian Koenig <christian.koenig@....com>,
        Chunming Zhou <David1.Zhou@....com>,
        Dave Airlie <airlied@...ux.ie>,
        kernel-janitors@...r.kernel.org,
        Maling list - DRI developers 
        <dri-devel@...ts.freedesktop.org>,
        amd-gfx list <amd-gfx@...ts.freedesktop.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] drm/radeon: remove set but not used variable 'rdev'

On Thu, Nov 8, 2018 at 9:04 AM YueHaibing <yuehaibing@...wei.com> wrote:
>
> From: Yue Haibing <yuehaibing@...wei.com>
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/gpu/drm/radeon/radeon_object.c: In function 'radeon_bo_unref':
> drivers/gpu/drm/radeon/radeon_object.c:317:24: warning:
>  variable 'rdev' set but not used [-Wunused-but-set-variable]
>
> It not used  any more after commit
>   e7e31600d3e2 ("drm/radeon: remove taking mclk_lock from radeon_bo_unref")
>
> Signed-off-by: Yue Haibing <yuehaibing@...wei.com>

Applied.  thanks!

Alex

> ---
>  drivers/gpu/drm/radeon/radeon_object.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_object.c b/drivers/gpu/drm/radeon/radeon_object.c
> index ba2fd29..c4b2e14 100644
> --- a/drivers/gpu/drm/radeon/radeon_object.c
> +++ b/drivers/gpu/drm/radeon/radeon_object.c
> @@ -314,11 +314,9 @@ struct radeon_bo *radeon_bo_ref(struct radeon_bo *bo)
>  void radeon_bo_unref(struct radeon_bo **bo)
>  {
>         struct ttm_buffer_object *tbo;
> -       struct radeon_device *rdev;
>
>         if ((*bo) == NULL)
>                 return;
> -       rdev = (*bo)->rdev;
>         tbo = &((*bo)->tbo);
>         ttm_bo_put(tbo);
>         *bo = NULL;
>
>
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives