linux-kernel - Re: [PATCH 4.4 026/114] btrfs: cleaner_kthread() doesnt need explicit freeze

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181109002203.GB7382@kroah.com>
Date:   Thu, 8 Nov 2018 16:22:03 -0800
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Sasha Levin <sashal@...nel.org>
Cc:     dsterba@...e.cz, linux-kernel@...r.kernel.org,
        Jiri Kosina <jkosina@...e.cz>, stable@...r.kernel.org
Subject: Re: [PATCH 4.4 026/114] btrfs: cleaner_kthread() doesnt need
 explicit freeze

On Thu, Nov 08, 2018 at 07:04:38PM -0500, Sasha Levin wrote:
> On Fri, Nov 09, 2018 at 12:28:10AM +0100, David Sterba wrote:
> > On Thu, Nov 08, 2018 at 01:50:41PM -0800, Greg Kroah-Hartman wrote:
> > > 4.4-stable review patch.  If anyone has any objections, please let me know.
> > 
> > > [ Upstream commit 838fe1887765f4cc679febea60d87d2a06bd300e ]
> > 
> > Please check the discussion under
> > 
> > https://lore.kernel.org/lkml/20181025141705.213937-8-sashal@kernel.org/
> > 
> > Jiri's reply:
> > 
> > "This patch just removes pointless try_to_freeze(), that's guaranteed
> > not to do anything and return immediately, as the btrfs kthread is not
> > freezable.  So I don't think it's needed in stable; the semantics is
> > equivalent before and after."
> > 
> > Sasha was fine with dropping the patch from stable candidates and this
> > has not changed. Thanks.
> 
> Indeed, I thought I dropped it but I see that I didn't. My bad, sorry.

I've now dropped this.  David, thanks for letting us know.

greg k-h