linux-kernel - Re: [PATCH v4 01/18] arm64: dts: qcom: qcs404: add base dts files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 9 Nov 2018 13:40:43 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Rob Herring <robh+dt@...nel.org>
Cc:     Andy Gross <andy.gross@...aro.org>,
        David Brown <david.brown@...aro.org>,
        Mark Rutland <mark.rutland@....com>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        "open list:ARM/QUALCOMM SUPPORT" <linux-soc@...r.kernel.org>,
        devicetree@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 01/18] arm64: dts: qcom: qcs404: add base dts files

On 09-11-18, 10:30, Vinod Koul wrote:

> > > +       clocks {
> > > +               xo_board: xo_board {
> > 
> > Build your dtbs with "W=12" and fix any warnings. You should get a
> > warning about '_'.
> 
> I did built it with W=1 though, so _ is not allowed?

I have fixed most of these with the exception of mmc-ddr-1_8v, as this
is documented in mmc bindings, so cant change this one. For this one I
am going to update gcc driver as well

> > > +       cpus {
> > > +               #address-cells = <1>;
> > > +               #size-cells = <0>;
> > > +
> > > +               CPU0: cpu@0 {
> > 
> > unit address is wrong.
> 
> Sorry am not sure I follow, can you please explain how..

Fixed now, thanks to Bjorn.

> > > +       memory@...00000 {
> > > +               device_type = "memory";
> > > +               /* We expect the bootloader to fill in the reg */
> > 
> > Can't you put in a default or base address at least.
> 
> Okay will try

Added now, will send update shortly

-- 
~Vinod