linux-kernel - Re: [PATCH 04/24] dt-bindings: leds: Add function and color properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bdd18dc6-0dee-5957-81d4-39254c7ad74d@gmail.com>
Date:   Fri, 9 Nov 2018 10:32:01 +0200
From:   Vesa Jääskeläinen <dachaac@...il.com>
To:     Jacek Anaszewski <jacek.anaszewski@...il.com>,
        linux-leds@...r.kernel.org
Cc:     devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        pavel@....cz, robh@...nel.org,
        Baolin Wang <baolin.wang@...aro.org>,
        Daniel Mack <daniel@...que.org>, Dan Murphy <dmurphy@...com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Oleh Kravchenko <oleg@....org.ua>,
        Sakari Ailus <sakari.ailus@...ux.intel.com>,
        Simon Shields <simon@...eageos.org>,
        Xiaotong Lu <xiaotong.lu@...eadtrum.com>
Subject: Re: [PATCH 04/24] dt-bindings: leds: Add function and color
 properties

On 07/11/2018 0.07, Jacek Anaszewski wrote:
> Introduce dedicated properties for conveying information about
> LED function and color. Mark old "label" property as deprecated.
> 
> Signed-off-by: Jacek Anaszewski <jacek.anaszewski@...il.com>
> Cc: Baolin Wang <baolin.wang@...aro.org>
> Cc: Daniel Mack <daniel@...que.org>
> Cc: Dan Murphy <dmurphy@...com>
> Cc: Linus Walleij <linus.walleij@...aro.org>
> Cc: Oleh Kravchenko <oleg@....org.ua>
> Cc: Sakari Ailus <sakari.ailus@...ux.intel.com>
> Cc: Simon Shields <simon@...eageos.org>
> Cc: Xiaotong Lu <xiaotong.lu@...eadtrum.com>
> ---
>   Documentation/devicetree/bindings/leds/common.txt | 52 +++++++++++++++++++----
>   1 file changed, 44 insertions(+), 8 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/leds/common.txt b/Documentation/devicetree/bindings/leds/common.txt
> index aa13998..3efc826 100644
> --- a/Documentation/devicetree/bindings/leds/common.txt
> +++ b/Documentation/devicetree/bindings/leds/common.txt
> @@ -10,14 +10,20 @@ can influence the way of the LED device initialization, the LED components
>   have to be tightly coupled with the LED device binding. They are represented
>   by child nodes of the parent LED device binding.
>   
> +
>   Optional properties for child nodes:
>   - led-sources : List of device current outputs the LED is connected to. The
>   		outputs are identified by the numbers that must be defined
>   		in the LED device binding documentation.
> +- function: LED functon. Use one of the LED_FUNCTION_* prefixed definitions
> +	    from the header include/dt-bindings/leds/functions.h.
> +	    If there is no matching LED_FUNCTION available, add a new one.
> +- color : Color of the LED.

We have had for years out-of-tree patch for multi color gpio led driver 
which extends this concept with multiple colors. Then in sysfs there has 
been possibility to control the color and otherwise use blinking or 
other features.

Our need is multi color status led of the device which includes 
different kind of blinkings and colors on different situations.

Current in-tree gpio led driver just wasn't atomic enough and a bit 
clumsy interface for handling this.

Now that this is being looked at could we come up with solution that we 
could define multiple colors for one led in device tree and then we 
could work on getting the driver upstreamed?

What we did was generally:

leds-multi {
	compatible = "gpio-multi-leds";

	status {
		gpios = <...>;
		linux,default-trigger = "none";
		deafult-state = "keep";

		color-red {
			pin-mask = <0x01>;
		};

		color-green {
			pin-mask = <0x02>;
		};

		color-orange {
			pin-mask = <0x03>;
		};
	};
};

Thanks,
Vesa Jääskeläinen