linux-kernel - Re: [PATCH] exec: make de

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181109092123.GA29945@redhat.com>
Date:   Fri, 9 Nov 2018 10:21:24 +0100
From:   Oleg Nesterov <oleg@...hat.com>
To:     Chanho Min <chanho.min@....com>
Cc:     "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Pavel Machek <pavel@....cz>, Len Brown <len.brown@...el.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        "Eric W. Biederman" <ebiederm@...ssion.com>,
        Christian Brauner <christian@...uner.io>,
        Anna-Maria Gleixner <anna-maria@...utronix.de>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-fsdevel@...r.kernel.org,
        Seungho Park <seungho1.park@....com>,
        Inkyu Hwang <inkyu.hwang@....com>,
        Donghwan Jung <donghwan.jung@....com>,
        Jongsung Kim <neidhard.kim@....com>
Subject: Re: [PATCH] exec: make de_thread() freezable

On 11/09, Chanho Min wrote:
>
> @@ -1083,7 +1084,7 @@ static int de_thread(struct task_struct *tsk)
>  	while (sig->notify_count) {
>  		__set_current_state(TASK_KILLABLE);
>  		spin_unlock_irq(lock);
> -		schedule();
> +		freezable_schedule();

Thanks, but please note another schedule() in "if (!thread_group_leader(tsk))"
branch, we probably want to change it too?

Oleg.