linux-kernel - Re: [PATCH v7 0/2] Add ThunderX2 SoC Performance Monitoring Unit driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 9 Nov 2018 15:52:32 +0530
From:   Ganapatrao Kulkarni <gklkml16@...il.com>
To:     Ganapatrao Kulkarni <Ganapatrao.Kulkarni@...ium.com>
Cc:     linux-doc@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
        linux-arm-kernel@...ts.infradead.org,
        Will Deacon <Will.Deacon@....com>,
        Mark Rutland <mark.rutland@....com>, suzuki.poulose@....com,
        "Nair, Jayachandran" <Jayachandran.Nair@...ium.com>,
        Robert Richter <Robert.Richter@...ium.com>,
        Vadim.Lomovtsev@...ium.com, Jan.Glauber@...ium.com
Subject: Re: [PATCH v7 0/2] Add ThunderX2 SoC Performance Monitoring Unit driver

Hi Mark,

can you please review this series?

On Thu, Oct 25, 2018 at 11:29 AM Kulkarni, Ganapatrao
<Ganapatrao.Kulkarni@...ium.com> wrote:
>
> This patchset adds PMU driver for Cavium's ThunderX2 SoC UNCORE devices.
> The SoC has PMU support in L3 cache controller (L3C) and in the
> DDR4 Memory Controller (DMC).
>
> v7:
>         Incorporated review comments [3].
>         Modified driver as loadable module.
>         Updated Documentation with Event description.
>         Removed per-channel(no SMC calls) sampling implementation(
>         Since DMC and L3C channels are interleave, we have decided to
>         sample channel zero and prorate it to account for a Device).
>
> [3] https://patchwork.kernel.org/patch/10479203/
>
> v6:
>         Rebased to 4.18-rc1
>         Updated with comments from John Garry[3]
>
> [3] https://lkml.org/lkml/2018/5/17/408
>
> v5:
>         Incorporated review comments from Mark Rutland[2]
> v4:
>         Incorporated review comments from Mark Rutland[1]
>
> [1] https://www.spinics.net/lists/arm-kernel/msg588563.html
> [2] https://lkml.org/lkml/2018/4/26/376
>
> v3:
>         Fixed warning reported by kbuild robot
>
> v2:
>         Rebased to 4.12-rc1
>         Removed Arch VULCAN dependency.
>         Update SMC call parameters as per latest firmware.
>
> v1:
>         Initial patch
>
> Ganapatrao Kulkarni (2):
>   perf, uncore: Adding documentation for ThunderX2 pmu uncore driver
>   ThunderX2, perf : Add Cavium ThunderX2 SoC UNCORE PMU driver
>
>  Documentation/perf/thunderx2-pmu.txt | 106 ++++
>  drivers/perf/Kconfig                 |   9 +
>  drivers/perf/Makefile                |   1 +
>  drivers/perf/thunderx2_pmu.c         | 867 +++++++++++++++++++++++++++
>  include/linux/cpuhotplug.h           |   1 +
>  5 files changed, 984 insertions(+)
>  create mode 100644 Documentation/perf/thunderx2-pmu.txt
>  create mode 100644 drivers/perf/thunderx2_pmu.c
>
> --
> 2.18.0
>

thanks
Ganapat