linux-kernel - Re: [PATCH v2] x86/cpu: fix prototype warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181109105538.GA21243@zn.tnic>
Date:   Fri, 9 Nov 2018 11:55:38 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     wang.yi59@....com.cn, Greg KH <gregkh@...uxfoundation.org>
Cc:     matz@...e.de, tglx@...utronix.de, mingo@...hat.com, hpa@...or.com,
        x86@...nel.org, suravee.suthikulpanit@....com, puwen@...on.cn,
        davidwang@...oxin.com, linux-kernel@...r.kernel.org,
        zhong.weidong@....com.cn
Subject: Re: [PATCH v2] x86/cpu: fix prototype warning

On Fri, Nov 09, 2018 at 08:43:12AM +0800, wang.yi59@....com.cn wrote:
> Yeah, so that is. However, I suppose we should not enable this by default
> before we fix ALL of these warning,

Yeah, the build is really noisy now.

> which is really a  hard work. :)

Yeah, I wonder if adding this to a kernel janitors TODO list or somesuch
would help speeding up the process.

Maybe Greg knows.

Greg, the question is whether we can get people to help out with

  -Wmissing-prototypes

fixes around the tree. Currently, there are ~1400 warnings and we want
to have 0 and then add that option to the main Makefile.

It is very easy to do: you simply build the kernel with W=1, choose one
-Wmissing-prototypes warning and fix it by adding a function prototype
or declaring the function static.

It should be a pretty easy for newbies to get involved...

> Aha, I will try my best to to work on this, and as you said, that's a long
> road to go, so maybe I would only work on modules which I am familiar with. ;-)

Sounds good.

Thx.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.