linux-kernel - Re: [PATCH] drivers/android/binder.c: Remove duplicate header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181109112434.GA29324@kroah.com>
Date:   Fri, 9 Nov 2018 03:24:34 -0800
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Brajeswar Ghosh <brajeswar.linux@...il.com>
Cc:     arve@...roid.com, tkjos@...roid.com, maco@...roid.com,
        joel@...lfernandes.org, devel@...verdev.osuosl.org,
        sabyasachi.linux@...il.com, jrdr.linux@...il.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers/android/binder.c: Remove duplicate header

On Fri, Nov 09, 2018 at 09:44:25AM +0530, Brajeswar Ghosh wrote:
> Remove binder_trace.h which is included more than once
> 
> Signed-off-by: Brajeswar Ghosh <brajeswar.linux@...il.com>
> ---
>  drivers/android/binder.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/android/binder.c b/drivers/android/binder.c
> index cb30a524d16d..719f35a5c04b 100644
> --- a/drivers/android/binder.c
> +++ b/drivers/android/binder.c
> @@ -5852,6 +5852,5 @@ static int __init binder_init(void)
>  device_initcall(binder_init);
>  
>  #define CREATE_TRACE_POINTS
> -#include "binder_trace.h"
>  
>  MODULE_LICENSE("GPL v2");

Are you sure about this?  Did you test the tracepoint functionality
after removing that line?  I think you just broke it :(

thanks,

greg k-h