linux-kernel - Re: [Xen-devel] [PATCH] xen: fix xen_qlock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <67e80fc6-e47a-3ba2-09ce-b1c8557cc74c@suse.com>
Date:   Fri, 9 Nov 2018 16:35:43 +0100
From:   Juergen Gross <jgross@...e.com>
To:     Sander Eikelenboom <linux@...elenboom.it>,
        linux-kernel@...r.kernel.org, xen-devel@...ts.xenproject.org,
        x86@...nel.org
Cc:     sstabellini@...nel.org, stable@...r.kernel.org, mingo@...hat.com,
        bp@...en8.de, hpa@...or.com, boris.ostrovsky@...cle.com,
        tglx@...utronix.de
Subject: Re: [Xen-devel] [PATCH] xen: fix xen_qlock_wait()

On 09/11/2018 16:29, Sander Eikelenboom wrote:
> On 09/11/18 16:20, Juergen Gross wrote:
>> On 09/11/2018 16:02, Sander Eikelenboom wrote:
>>> On 09/11/18 13:04, Juergen Gross wrote:
>>>> Commit a856531951dc80 ("xen: make xen_qlock_wait() nestable")
>>>> introduced a regression for Xen guests running fully virtualized
>>>> (HVM or PVH mode). The Xen hypervisor wouldn't return from the poll
>>>> hypercall with interrupts disabled in case of an interrupt (for PV
>>>> guests it does).
>>>>
>>>> So instead of disabling interrupts in xen_qlock_wait() use a nesting
>>>> counter to avoid calling xen_clear_irq_pending() in case
>>>> xen_qlock_wait() is nested.
>>>>
>>>> Fixes: a856531951dc80 ("xen: make xen_qlock_wait() nestable")
>>>> Cc: stable@...r.kernel.org
>>>> Signed-off-by: Juergen Gross <jgross@...e.com>
>>>
>>> Although you don't seem too interested, you can stick on a:
>>> Tested-by: Sander Eikelenboom <linux@...elenboom.it>
>>> if you like.
>>
>> I am interested.
>>
>> OTOH I wanted to post the patch officially to give others the chance to
>> send remarks.
> 
> OK, would be nice to at least be CC'ed on patches going upstream when
> you have been reporting stuff.

Sorry, my fault.


Juergen