linux-kernel - RE: [PATCH v2] x86/cpu: fix prototype warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3e5713c2f323453d80bdd2259e3392e5@AcuMS.aculab.com>
Date:   Fri, 9 Nov 2018 16:07:01 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'Thomas Gleixner' <tglx@...utronix.de>,
        Borislav Petkov <bp@...en8.de>
CC:     Yi Wang <wang.yi59@....com.cn>, Michael Matz <matz@...e.de>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "hpa@...or.com" <hpa@...or.com>, "x86@...nel.org" <x86@...nel.org>,
        "suravee.suthikulpanit@....com" <suravee.suthikulpanit@....com>,
        "puwen@...on.cn" <puwen@...on.cn>,
        "davidwang@...oxin.com" <davidwang@...oxin.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "zhong.weidong@....com.cn" <zhong.weidong@....com.cn>
Subject: RE: [PATCH v2] x86/cpu: fix prototype warning

From: Thomas Gleixner
> Sent: 08 November 2018 15:36
> On Thu, 8 Nov 2018, Borislav Petkov wrote:
> > And frankly, I don't see why we should be fixing all those. So what if a
> > global function does't have a previous prototype declaration?!
> 
> Global function declarations must have a prototype definition, really.
> 
> Otherwise you can change the function signature and all callers which use
> the old unchanged prototype are hosed.

I bet there are at least double-figures of real bugs out there.

The next on the list should be -Wwriteable-strings.
Usually just needs a few 'const' sprinkled.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)