linux-kernel - Re: [PATCH 3/8] sparc: prom: use property "name" directly to construct node names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20181108.191320.1503108955211963619.davem@davemloft.net>
Date:   Thu, 08 Nov 2018 19:13:20 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     robh@...nel.org
Cc:     frowand.list@...il.com, linux-kernel@...r.kernel.org,
        sparclinux@...r.kernel.org
Subject: Re: [PATCH 3/8] sparc: prom: use property "name" directly to
 construct node names

From: Rob Herring <robh@...nel.org>
Date: Wed,  7 Nov 2018 16:31:46 -0600

> In preparation to remove direct accesses to the device_node.name
> pointer, retrieve the node name from the "name" property instead.
> 
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: sparclinux@...r.kernel.org
> Signed-off-by: Rob Herring <robh@...nel.org>

On some 32-bit sparcs, the OF runs in non-cached memory.

Sucking in the OF device tree take a signficant amount of the
boot time on such systems.

And these changes are going to make it even slower.

Please just put a wrapper around dp->name or whatever and use that,
instead of making more get property OF calls which can be very
expensive.