linux-kernel - Re: [git pull] mount API series

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2f4a2d58-dc7b-3a8f-65aa-9db432ce0a1e@redhat.com>
Date:   Sat, 10 Nov 2018 14:19:44 +0000
From:   Steven Whitehouse <swhiteho@...hat.com>
To:     "Eric W. Biederman" <ebiederm@...ssion.com>
Cc:     Al Viro <viro@...IV.linux.org.uk>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [git pull] mount API series

Hi,


On 31/10/18 15:38, Eric W. Biederman wrote:
> Al Viro <viro@...IV.linux.org.uk> writes:
>
>> 	mount API series from David Howells.  Last cycle's objections
>> had been of the "I'd do it differently" variety and with no such
>> differently done variants having ever materialized over several
>> cycles...
> Absolutely not.
>
> My objections fundamentally is that I can find real problems when I look
> at the code.  Further the changes have not been incremental changes that
> have evolved the code from one state to another but complete
> replacements of code that make code review very difficult and bisection
> completely inapplicable.
>
> I also object that this series completely fails to fix the worst but I
> have ever seen in the mount API.  Whit no real intrest shown in working
> to fix it.
>
> A couple of bugs that I can see quickly.  Several of which I have
> previously reported:
>
> - There is an easily triggered NULL pointer deference with open_tree
>    and mount propagation.
>
>
Can you share some details of what this NULL dereference is? David and 
Al have been working on the changes as requested by Linus later in this 
thread, and they'd like to tidy up this issue too at the same time if 
possible. We are not asking you to actually provide a fix, in case you 
are too busy to do so, however it would be good to know what the issue 
is so that we can make sure that it is resolved in the next round of 
patches,

Steve.