linux-kernel - Re: [PATCH 4.14 07/31] clk: tegra: Add quirk for getting CDEV1/2 clocks on Tegra20

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181110152417.GC24724@kroah.com>
Date:   Sat, 10 Nov 2018 07:24:17 -0800
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Dmitry Osipenko <digetx@...il.com>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Peter De Schrijver <pdeschrijver@...dia.com>,
        Thierry Reding <treding@...dia.com>,
        Sasha Levin <sashal@...nel.org>
Subject: Re: [PATCH 4.14 07/31] clk: tegra: Add quirk for getting CDEV1/2
 clocks on Tegra20

On Fri, Nov 09, 2018 at 09:32:15PM +0300, Dmitry Osipenko wrote:
> On 09.11.2018 0:52, Greg Kroah-Hartman wrote:
> > 4.14-stable review patch.  If anyone has any objections, please let me know.
> > 
> > ------------------
> > 
> > [ Upstream commit 5d797111afe12e488e08432fd9b372fae2cc7e93 ]
> > 
> > CDEV1 and CDEV2 clocks are a bit special case, their parent clock is
> > created by the pinctrl driver. It should be possible for clk user to
> > request these clocks before pinctrl driver got probed and hence user will
> > get an orphaned clock. That might be undesirable because user may expect
> > parent clock to be enabled by the child, so let's return -EPROBE_DEFER
> > till parent clock appears.
> > 
> > Signed-off-by: Dmitry Osipenko <digetx@...il.com>
> > Acked-by: Peter De Schrijver <pdeschrijver@...dia.com>
> > Signed-off-by: Thierry Reding <treding@...dia.com>
> > Signed-off-by: Sasha Levin <sashal@...nel.org>
> > ---
> 
> [snip]
> 
> Hello Greg,
> 
> You should either pick up c59487075659 in addition or don't backport
> anything at all. The original problem was gone while we were trying to
> fix it and these commits only helping to ensure that the problem won't
> re-occur, AFAIK it shouldn't be necessary to backport any of these
> patches.

Thanks, I've now just dropped this patch from the 4.14.y queue.

greg k-h