linux-kernel - Re: [PATCH] EDAC: clean an indentation issues, replace spaces for tabs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181110155851.GC20023@zn.tnic>
Date:   Sat, 10 Nov 2018 16:58:51 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     Colin King <colin.king@...onical.com>
Cc:     Mark Gross <mark.gross@...el.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Ranganathan Desikan <ravi@...ztechnologies.com>,
        "Arvind R ." <arvino55@...il.com>, linux-edac@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] EDAC: clean an indentation issues, replace spaces for
 tabs

On Fri, Nov 09, 2018 at 01:37:57PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> Trivial fix to clean up an indentation issues, replacing 7 space chars
> for a tab and also inserting a missing indentation

Pls see section "2) Describe your changes" in

  Documentation/process/submitting-patches.rst

about how to formulate your commit message. Especially this:

"Describe your changes in imperative mood, e.g. "make xyzzy do frotz"
instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy to
do frotz", as if you are giving orders to the codebase to change its
behaviour."

> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/edac/e752x_edac.c   | 4 ++--
>  drivers/edac/i3000_edac.c   | 4 ++--
>  drivers/edac/i5000_edac.c   | 4 ++--
>  drivers/edac/i7core_edac.c  | 2 +-
>  drivers/edac/i82975x_edac.c | 4 ++--
>  5 files changed, 9 insertions(+), 9 deletions(-)

Anyway, fixed up and applied,
thanks.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.