[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Sun, 11 Nov 2018 17:51:22 +0800
From: kbuild test robot <lkp@...el.com>
To: Chanho Min <chanho.min@....com>
Cc: kbuild-all@...org, "Rafael J. Wysocki" <rjw@...ysocki.net>,
Pavel Machek <pavel@....cz>, Len Brown <len.brown@...el.com>,
Andrew Morton <akpm@...ux-foundation.org>,
"Eric W. Biederman" <ebiederm@...ssion.com>,
Christian Brauner <christian@...uner.io>,
Oleg Nesterov <oleg@...hat.com>,
Anna-Maria Gleixner <anna-maria@...utronix.de>,
linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
Seungho Park <seungho1.park@....com>,
Chanho Min <chanho.min@....com>
Subject: Re: [PATCH] freezer: fix freeze timeout on exec
Hi Chanho,
I love your patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v4.20-rc1 next-20181109]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Chanho-Min/freezer-fix-freeze-timeout-on-exec/20181111-171200
config: i386-randconfig-x002-201845 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All errors (new ones prefixed by >>):
kernel/signal.c: In function 'zap_other_threads':
>> kernel/signal.c:1283:3: error: implicit declaration of function 'cancel_freezing_thaw_task' [-Werror=implicit-function-declaration]
cancel_freezing_thaw_task(t);
^~~~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +/cancel_freezing_thaw_task +1283 kernel/signal.c
1260
1261 /*
1262 * Nuke all other threads in the group.
1263 */
1264 int zap_other_threads(struct task_struct *p)
1265 {
1266 struct task_struct *t = p;
1267 int count = 0;
1268
1269 p->signal->group_stop_count = 0;
1270
1271 while_each_thread(p, t) {
1272 task_clear_jobctl_pending(t, JOBCTL_PENDING_MASK);
1273 count++;
1274
1275 /* Don't bother with already dead threads */
1276 if (t->exit_state)
1277 continue;
1278
1279 /*
1280 * we can check sig->group_exit_task to detect de_thread,
1281 * but perhaps it doesn't hurt if the caller is do_group_exit
1282 */
> 1283 cancel_freezing_thaw_task(t);
1284 sigaddset(&t->pending.signal, SIGKILL);
1285 signal_wake_up(t, 1);
1286 }
1287
1288 return count;
1289 }
1290
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
Download attachment ".config.gz" of type "application/gzip" (27026 bytes)
Powered by blists - more mailing lists