[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sun, 11 Nov 2018 21:03:28 +0100
From: Jacek Anaszewski <jacek.anaszewski@...il.com>
To: Pavel Machek <pavel@....cz>
Cc: linux-leds@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, robh@...nel.org,
Xiaotong Lu <xiaotong.lu@...eadtrum.com>,
Baolin Wang <baolin.wang@...aro.org>
Subject: Re: [PATCH 05/24] dt-bindings: sc27xx-blt: Add function and color
properties
Hi Pavel.
On 11/11/2018 03:29 PM, Pavel Machek wrote:
> On Tue 2018-11-06 23:07:13, Jacek Anaszewski wrote:
>> Refer to new "function" and "color" properties and mark "label"
>> as deprecated.
>>
>> Signed-off-by: Jacek Anaszewski <jacek.anaszewski@...il.com>
>> Cc: Xiaotong Lu <xiaotong.lu@...eadtrum.com>
>> Cc: Baolin Wang <baolin.wang@...aro.org>
>
> Don't you want to keep both color and label? New dts on old kernel
> should still work...?
>
> Ok, I see these are only examples....
Right, this is only an example, and we'd rather want to encourage
people to switch to using new LED naming.
>> @@ -25,17 +27,17 @@ led-controller@200 {
>> reg = <0x200>;
>>
>> led@0 {
>> - label = "red";
>> + color = "red";
>> reg = <0x0>;
>> };
>>
>> led@1 {
>> - label = "green";
>> + color = "green";
>> reg = <0x1>;
>> };
>>
>> led@2 {
>> - label = "blue";
>> + color = "blue";
>> reg = <0x2>;
>> };
>> };
>
--
Best regards,
Jacek Anaszewski
Powered by blists - more mailing lists