[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Sun, 11 Nov 2018 21:51:49 +0100
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Cc: Boris Brezillon <boris.brezillon@...tlin.com>,
Richard Weinberger <richard@....at>,
David Woodhouse <dwmw2@...radead.org>,
Brian Norris <computersforpeace@...il.com>,
Marek Vasut <marek.vasut@...il.com>,
linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mtd: rawnand: fsmc: Fix unchecked return value in
fsmc_read_page_hwecc
Hi Gustavo,
"Gustavo A. R. Silva" <gustavo@...eddedor.com> wrote on Wed, 10 Oct
2018 17:58:58 +0200:
> Check return value of nand_read_data_op.
>
> Notice that, currently, all instances of nand_read_data_op() are
> being checked, with the exception of two of them in marvell_nand
> driver, in which the caller function explicitly returns 0 every
> time.
>
> Also, notice that I moved the declaration of *ret* to the top of
> fsmc_read_page_hwecc().
>
> Addresses-Coverity-ID: 1471968 ("Unchecked return value")
> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
> ---
Applied to nand/next.
Thanks,
Miquèl
Powered by blists - more mailing lists