[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Sun, 11 Nov 2018 09:44:51 +0100
From: Takashi Iwai <tiwai@...e.de>
To: "Andy Shevchenko" <andy.shevchenko@...il.com>
Cc: "Ayman Bagabas" <ayman.bagabas@...il.com>,
"ALSA Development Mailing List" <alsa-devel@...a-project.org>,
"Hui Wang" <hui.wang@...onical.com>,
"Andy Shevchenko" <andy@...radead.org>,
"Darren Hart" <dvhart@...radead.org>,
"Jaroslav Kysela" <perex@...ex.cz>,
"Kailang Yang" <kailang@...ltek.com>,
"Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>,
"Platform Driver" <platform-driver-x86@...r.kernel.org>
Subject: Re: [PATCH v4 3/3] ALSA: hda: add support for Huawei WMI micmute LED
On Sat, 10 Nov 2018 15:26:55 +0100,
Andy Shevchenko wrote:
>
> On Sat, Nov 10, 2018 at 1:46 AM Ayman Bagabas <ayman.bagabas@...il.com> wrote:
> >
> > Some of Huawei laptops come with a LED in the micmute key. This patch
> > enables and disable this LED accordingly.
> > This enables micmute LED for:
> > 1. Matebook X (19e5:3200), (19e5:3201)
> > 2. Matebook X Pro (19e5:3204)
> >
> > Signed-off-by: Ayman Bagabas <ayman.bagabas@...il.com>
> > ---
> > sound/pci/hda/huawei_wmi_helper.c | 47 +++++++++++++++++++++++++++++++
> > sound/pci/hda/patch_realtek.c | 14 ++++++++-
> > 2 files changed, 60 insertions(+), 1 deletion(-)
> > create mode 100644 sound/pci/hda/huawei_wmi_helper.c
> >
> > diff --git a/sound/pci/hda/huawei_wmi_helper.c b/sound/pci/hda/huawei_wmi_helper.c
> > new file mode 100644
> > index 000000000000..7c91f914ffba
> > --- /dev/null
> > +++ b/sound/pci/hda/huawei_wmi_helper.c
> > @@ -0,0 +1,47 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/* Helper functions for Huawei WMI micmute LED;
> > + * to be included from codec driver
> > + */
> > +
>
> > +#if IS_ENABLED(CONFIG_HUAWEI_LAPTOP)
>
> ENABLED or REACHABLE?
FWIW, other similar codes take ENABLED. It's dynamic binding, and the
codec driver may be re-bound even if it's a built-in.
Takashi
Powered by blists - more mailing lists