linux-kernel - Re: [PATCH v7 02/13] arch/x86: Rename the RDT functions and definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8085e1cc-484a-ff75-38ef-7f4da9fb847d@amd.com>
Date:   Mon, 12 Nov 2018 20:51:45 +0000
From:   "Moger, Babu" <Babu.Moger@....com>
To:     Borislav Petkov <bp@...en8.de>
CC:     "tglx@...utronix.de" <tglx@...utronix.de>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "corbet@....net" <corbet@....net>,
        "fenghua.yu@...el.com" <fenghua.yu@...el.com>,
        "reinette.chatre@...el.com" <reinette.chatre@...el.com>,
        "peterz@...radead.org" <peterz@...radead.org>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "hpa@...or.com" <hpa@...or.com>, "x86@...nel.org" <x86@...nel.org>,
        "mchehab+samsung@...nel.org" <mchehab+samsung@...nel.org>,
        "arnd@...db.de" <arnd@...db.de>,
        "kstewart@...uxfoundation.org" <kstewart@...uxfoundation.org>,
        "pombredanne@...b.com" <pombredanne@...b.com>,
        "rafael@...nel.org" <rafael@...nel.org>,
        "kirill.shutemov@...ux.intel.com" <kirill.shutemov@...ux.intel.com>,
        "tony.luck@...el.com" <tony.luck@...el.com>,
        "qianyue.zj@...baba-inc.com" <qianyue.zj@...baba-inc.com>,
        "xiaochen.shen@...el.com" <xiaochen.shen@...el.com>,
        "pbonzini@...hat.com" <pbonzini@...hat.com>,
        "Singh, Brijesh" <brijesh.singh@....com>,
        "Hurwitz, Sherry" <sherry.hurwitz@....com>,
        "dwmw2@...radead.org" <dwmw2@...radead.org>,
        "Lendacky, Thomas" <Thomas.Lendacky@....com>,
        "luto@...nel.org" <luto@...nel.org>,
        "joro@...tes.org" <joro@...tes.org>,
        "jannh@...gle.com" <jannh@...gle.com>,
        "vkuznets@...hat.com" <vkuznets@...hat.com>,
        "rian@...m.mit.edu" <rian@...m.mit.edu>,
        "jpoimboe@...hat.com" <jpoimboe@...hat.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>
Subject: Re: [PATCH v7 02/13] arch/x86: Rename the RDT functions and
 definitions



On 11/12/18 1:46 PM, Borislav Petkov wrote:
> On Mon, Nov 12, 2018 at 07:25:02PM +0000, Moger, Babu wrote:
>>>> @@ -637,10 +637,11 @@ int rdt_get_mon_l3_config(struct rdt_resource *r)
>>>>  	 *
>>>>  	 * For a 35MB LLC and 56 RMIDs, this is ~1.8% of the LLC.
>>>>  	 */
>>>> -	intel_cqm_threshold = boot_cpu_data.x86_cache_size * 1024 / r->num_rmid;
>>>> +	resctrl_cqm_threshold = boot_cpu_data.x86_cache_size * 1024 /
>>>> +				r->num_rmid;
>>>
>>> No need to break that line here.
>>
>> Without the line break, checkpatch complains for "line over 80
>> characters".  Do you think we can ignore those?
> 
> To quote from the tip handbook which is in preparation right now:
> 
> "+The 80 character rule is not a strict rule, so please use common sense when
>  +breaking lines."
> 
> In this particular case, it is more readable IMO to leave the line unbroken:
> 
> 	resctrl_cqm_threshold = boot_cpu_data.x86_cache_size * 1024 / r->num_rmid;
> 
> What is even more readable though is:
> 
> 	unsigned int cl_size = boot_cpu_data.x86_cache_size;
> 
> 	...
> 
> 	resctrl_cqm_threshold = cl_size * 1024 / r->num_rmid;
> 
> and now you have a win-win situation. :)

Yes. Makes sense. Thanks

> 
> Thx.
>