linux-kernel - Re: [PATCH RFC] bluetooth: add uart h4 devices via serdev/devicetree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181112215812.18ebca35@aktux>
Date:   Mon, 12 Nov 2018 21:59:34 +0100
From:   Andreas Kemnade <andreas@...nade.info>
To:     Sebastian Reichel <sebastian.reichel@...labora.com>
Cc:     marcel@...tmann.org, johan.hedberg@...il.com,
        linux-bluetooth@...r.kernel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, letux-kernel@...nphoenux.org
Subject: Re: [PATCH RFC] bluetooth: add uart h4 devices via
 serdev/devicetree

Hi,

On Sun, 11 Nov 2018 03:46:48 +0100
Sebastian Reichel <sebastian.reichel@...labora.com> wrote:

> Hi,
> 
> On Sun, Nov 11, 2018 at 12:20:34AM +0100, Andreas Kemnade wrote:
> > This is a first try to be able to use h4 devices specified in
> > the devicetree, so you do not need to call hciattach and
> > it can be automatically probed.
> > 
> > Of course, proper devicetree bindings documentation is
> > missing. And also you would extend that by regulator/
> > enable gpio settings.
> > 
> > But before proceeding further it should be checked if the
> > general way of doing things is right.
> > 
> > Signed-off-by: Andreas Kemnade <andreas@...nade.info>
> > ---  
> 
> Patch looks good to me, just one note
> 
I found one thing myself:
Shouldn't we have a generic compatible string like "generic-h4".
ehci-platform.c has for example:
        { .compatible = "generic-ehci", },

Regards,
Andreas

Content of type "application/pgp-signature" skipped