linux-kernel - Re: [PATCH 02/24] leds: core: Add support for composing LED class device names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdZwgZ=PmX3PEpR-F76BZ5g9hzvQYc_3QfFYhHvBHqp4Tw@mail.gmail.com>
Date:   Mon, 12 Nov 2018 22:25:47 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     dachaac@...il.com
Cc:     Jacek Anaszewski <jacek.anaszewski@...il.com>,
        Pavel Machek <pavel@....cz>, linux-leds@...r.kernel.org,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Rob Herring <robh@...nel.org>,
        Baolin Wang <baolin.wang@...aro.org>,
        Daniel Mack <daniel@...que.org>, dmurphy@...com,
        oleg@....org.ua, Sakari Ailus <sakari.ailus@...ux.intel.com>,
        simon@...eageos.org, xiaotong.lu@...eadtrum.com
Subject: Re: [PATCH 02/24] leds: core: Add support for composing LED class
 device names

On Mon, Nov 12, 2018 at 1:02 AM Vesa Jääskeläinen <dachaac@...il.com> wrote:

> Couldn't we have here multiple variants that would then be chosen based
> on device tree definition?

It needs to be subsystem specific or something.
What you say make sense for things based on device
tree.

The problem hit me on an Intel laptop with several
USB keyboards.

OK maybe I am stupid for plugging in two USB keyboards,
but we should definately support it. Input/HID supports it
well.

Yours,
Linus Walleij