linux-kernel - Re: [PATCH 2/5] mm/memory_hotplug: Create add/del_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 12 Nov 2018 21:28:39 +0000
From:   Pavel Tatashin <pasha.tatashin@...een.com>
To:     Dan Williams <dan.j.williams@...el.com>
Cc:     osalvador@...hadventures.net,
        Andrew Morton <akpm@...ux-foundation.org>,
        Michal Hocko <mhocko@...e.com>,
        Yasuaki Ishimatsu <yasu.isimatu@...il.com>,
        rppt@...ux.vnet.ibm.com, malat@...ian.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Pasha Tatashin <pavel.tatashin@...rosoft.com>,
        Jérôme Glisse <jglisse@...hat.com>,
        Jonathan.Cameron@...wei.com,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        David Hildenbrand <david@...hat.com>,
        Dave Jiang <dave.jiang@...el.com>,
        Linux MM <linux-mm@...ck.org>,
        alexander.h.duyck@...ux.intel.com, osalvador@...e.de
Subject: Re: [PATCH 2/5] mm/memory_hotplug: Create add/del_device_memory
 functions

> 
> This collides with the refactoring of hmm, to be done in terms of
> devm_memremap_pages(). I'd rather not introduce another common
> function *beneath* hmm and devm_memremap_pages() and rather make
> devm_memremap_pages() the common function.
> 
> I plan to resubmit that cleanup after Plumbers. So, unless I'm
> misunderstanding some other benefit a nak from me on this patch as it
> stands currently.
> 

Ok, Dan, I will wait for your new refactoring series before continuing
reviewing this series.

Thank you,
Pasha