linux-kernel - Re: [PATCH 2/2] opp: ti-opp-supply: Correct the supply in _get_optimal_vdd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <312975f3-3cbd-3ece-20b6-ceb93421a3c9@ti.com>
Date:   Mon, 12 Nov 2018 15:49:22 -0600
From:   Dave Gerlach <d-gerlach@...com>
To:     Keerthy <j-keerthy@...com>, <vireshk@...nel.org>, <nm@...com>,
        <sboyd@...nel.org>
CC:     <linux-pm@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <t-kristo@...com>
Subject: Re: [PATCH 2/2] opp: ti-opp-supply: Correct the supply in
 _get_optimal_vdd_voltage call

On 11/06/2018 10:34 PM, Keerthy wrote:
> _get_optimal_vdd_voltage call provides new_supply_vbb->u_volt
> as the reference voltage while it should be really new_supply_vdd->u_volt.
> 
> Fixes: 9a835fa6e47 ("PM / OPP: Add ti-opp-supply driver")
> Signed-off-by: Keerthy <j-keerthy@...com>
> ---

Acked-by: Dave Gerlach <d-gerlach@...com>

Currently all corresponding vbb and vdd values provided by the device tree match
which is why this does not fail, but this was a typo by me and vdd is the
correct value to actually use.

Regards,
Dave

>  drivers/opp/ti-opp-supply.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/opp/ti-opp-supply.c b/drivers/opp/ti-opp-supply.c
> index 29e08a4..3f4fb4d 100644
> --- a/drivers/opp/ti-opp-supply.c
> +++ b/drivers/opp/ti-opp-supply.c
> @@ -288,7 +288,7 @@ static int ti_opp_supply_set_opp(struct dev_pm_set_opp_data *data)
>  	int ret;
>  
>  	vdd_uv = _get_optimal_vdd_voltage(dev, &opp_data,
> -					  new_supply_vbb->u_volt);
> +					  new_supply_vdd->u_volt);
>  
>  	if (new_supply_vdd->u_volt_min < vdd_uv)
>  		new_supply_vdd->u_volt_min = vdd_uv;
>