linux-kernel - LEDs on USB keyboards was Re: [PATCH 02/24] leds: core: Add support for composing LED class device names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181112221104.GC11942@amd>
Date:   Mon, 12 Nov 2018 23:11:04 +0100
From:   Pavel Machek <pavel@....cz>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     dachaac@...il.com, Jacek Anaszewski <jacek.anaszewski@...il.com>,
        linux-leds@...r.kernel.org,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Rob Herring <robh@...nel.org>,
        Baolin Wang <baolin.wang@...aro.org>,
        Daniel Mack <daniel@...que.org>, dmurphy@...com,
        oleg@....org.ua, Sakari Ailus <sakari.ailus@...ux.intel.com>,
        simon@...eageos.org, xiaotong.lu@...eadtrum.com
Subject: LEDs on USB keyboards was Re: [PATCH 02/24] leds: core: Add support
 for composing LED class device names

Hi!

> > Couldn't we have here multiple variants that would then be chosen based
> > on device tree definition?
> 
> It needs to be subsystem specific or something.
> What you say make sense for things based on device
> tree.
> 
> The problem hit me on an Intel laptop with several
> USB keyboards.
> 
> OK maybe I am stupid for plugging in two USB keyboards,
> but we should definately support it. Input/HID supports it
> well.

Plugging two USB keyboards should be supported.

Can we get some details... kernel version, architecture, maybe
.config, where/how it fails?

On my systems, keyboard leds are prefixed with device name, so I see
no chance for duplicities...

input5::capslock/    
input5::numlock/     
input5::scrolllock/

Thanks,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)