linux-kernel - Re: [PATCH] bpf: Remove unused variable in nsim

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181112141414.4dacb194@cakuba.netronome.com>
Date:   Mon, 12 Nov 2018 14:14:14 -0800
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Nathan Chancellor <natechancellor@...il.com>
Cc:     Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Quentin Monnet <quentin.monnet@...ronome.com>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] bpf: Remove unused variable in nsim_bpf

On Mon, 12 Nov 2018 15:10:42 -0700, Nathan Chancellor wrote:
> Clang warns:
> 
> drivers/net/netdevsim/bpf.c:557:30: error: unused variable 'state'
> [-Werror,-Wunused-variable]
>         struct nsim_bpf_bound_prog *state;
>                                     ^
> 1 error generated.
> 
> The declaration should have been removed in commit b07ade27e933 ("bpf:
> pass translate() as a callback and remove its ndo_bpf subcommand").
> 
> Signed-off-by: Nathan Chancellor <natechancellor@...il.com>

Acked-by: Jakub Kicinski <jakub.kicinski@...ronome.com>