linux-kernel - Re: [PATCH 1/1] iommu/vtd: Cleanup dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <518f02b4-8c4f-9451-68f1-cb014c4cc6eb@linux.intel.com>
Date:   Mon, 12 Nov 2018 09:17:44 +0800
From:   Lu Baolu <baolu.lu@...ux.intel.com>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     baolu.lu@...ux.intel.com, Joerg Roedel <joro@...tes.org>,
        David Woodhouse <dwmw2@...radead.org>, ashok.raj@...el.com,
        iommu@...ts.linux-foundation.org, linux-kernel@...r.kernel.org,
        Jacob Pan <jacob.jun.pan@...ux.intel.com>,
        Sohil Mehta <sohil.mehta@...el.com>
Subject: Re: [PATCH 1/1] iommu/vtd: Cleanup dma_remapping.h header

Hi,

On 11/10/18 4:35 PM, Christoph Hellwig wrote:
> On Sat, Nov 10, 2018 at 03:08:44PM +0800, Lu Baolu wrote:
>> Commit e61d98d8dad00 ("x64, x2apic/intr-remap: Intel vt-d, IOMMU
>> code reorganization") moved dma_remapping.h from drivers/pci/ to
>> current place. It is entirely VT-d specific, but uses a generic
>> name. This merges dma_remapping.h with include/linux/intel-iommu.h
>> and removes dma_remapping.h as the result.
> 
> This looks fine to me, thanks for doing the work.
> 
> Reviewed-by: Christoph Hellwig <hch@....de>

Thank you.

> 
>> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c
>> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c
>> @@ -34,7 +34,7 @@
>>   #include <drm/ttm/ttm_placement.h>
>>   #include <drm/ttm/ttm_bo_driver.h>
>>   #include <drm/ttm/ttm_module.h>
>> -#include <linux/dma_remapping.h>
>> +#include <linux/intel-iommu.h>
> 
> Btw, I don't think this driver has any business looking at Intel
> IOMMU driver internals, and the code doing so is more than gross.
> 
> Not really your job, but vmw_dma_select_mode really needs a rewrite with
> someone that has at least half a clue, and some taste.
> 
> Eventually we should also drop the intel_iommu_enabled export.
> 

Yes. Fair enough.

Best regards,
Lu Baolu