linux-kernel - Re: [PATCH V2 1/2] dt-bindings: mmc: sdhci-msm: Add SoC-specific compatible strings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <06819c2d-15bc-0b90-1504-232d2f327326@codeaurora.org>
Date:   Mon, 12 Nov 2018 12:26:34 +0530
From:   Veerabhadrarao Badiganti <vbadigan@...eaurora.org>
To:     adrian.hunter@...el.com, ulf.hansson@...aro.org,
        robh+dt@...nel.org, evgreen@...omium.org, dianders@...gle.com
Cc:     asutoshd@...eaurora.org, riteshh@...eaurora.org,
        stummala@...eaurora.org, sayalil@...eaurora.org,
        linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        Mark Rutland <mark.rutland@....com>
Subject: Re: [PATCH V2 1/2] dt-bindings: mmc: sdhci-msm: Add SoC-specific
 compatible strings


Please ignore this patch set. Right patch-set is V5. 
https://patchwork.kernel.org/project/linux-mmc/list/?series=41661

Sorry for the inconvenience.

Thanks

Veera


On 11/12/2018 12:08 PM, Veerabhadrarao Badiganti wrote:
> Add SoC-specific compatible strings for qcom-sdhci controller.
>
> Signed-off-by: Veerabhadrarao Badiganti <vbadigan@...eaurora.org>
> ---
>   Documentation/devicetree/bindings/mmc/sdhci-msm.txt | 21 +++++++++++++++++----
>   1 file changed, 17 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.txt b/Documentation/devicetree/bindings/mmc/sdhci-msm.txt
> index 502b3b8..b72871a 100644
> --- a/Documentation/devicetree/bindings/mmc/sdhci-msm.txt
> +++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.txt
> @@ -4,12 +4,25 @@ This file documents differences between the core properties in mmc.txt
>   and the properties used by the sdhci-msm driver.
>   
>   Required properties:
> -- compatible: Should contain:
> +- compatible: Should contain a SoC-specific string and a IP version string:
> +	version strings:
>   		"qcom,sdhci-msm-v4" for sdcc versions less than 5.0
> -		"qcom,sdhci-msm-v5" for sdcc versions >= 5.0
> +		"qcom,sdhci-msm-v5" for sdcc version 5.0
>   		For SDCC version 5.0.0, MCI registers are removed from SDCC
>   		interface and some registers are moved to HC. New compatible
>   		string is added to support this change - "qcom,sdhci-msm-v5".
> +	full compatible strings with SoC and version:
> +		"qcom,apq8084-sdhci", "qcom,sdhci-msm-v4"
> +		"qcom,msm8974-sdhci", "qcom,sdhci-msm-v4"
> +		"qcom,msm8916-sdhci", "qcom,sdhci-msm-v4"
> +		"qcom,msm8992-sdhci", "qcom,sdhci-msm-v4"
> +		"qcom,msm8996-sdhci", "qcom,sdhci-msm-v4"
> +		"qcom,sdm845-sdhci", "qcom,sdhci-msm-v5"
> +		"qcom,qcs404-sdhci", "qcom,sdhci-msm-v5"
> +	NOTE that some old device tree files may be floating around that only
> +	have the string "qcom,sdhci-msm-v4" without the SoC compatible string
> +	but doing that should be considered a deprecated practice.
> +
>   - reg: Base address and length of the register in the following order:
>   	- Host controller register map (required)
>   	- SD Core register map (required)
> @@ -29,7 +42,7 @@ Required properties:
>   Example:
>   
>   	sdhc_1: sdhci@...24900 {
> -		compatible = "qcom,sdhci-msm-v4";
> +		compatible = "qcom,msm8974-sdhci", "qcom,sdhci-msm-v4";
>   		reg = <0xf9824900 0x11c>, <0xf9824000 0x800>;
>   		interrupts = <0 123 0>;
>   		bus-width = <8>;
> @@ -46,7 +59,7 @@ Example:
>   	};
>   
>   	sdhc_2: sdhci@...a4900 {
> -		compatible = "qcom,sdhci-msm-v4";
> +		compatible = "qcom,msm8974-sdhci", "qcom,sdhci-msm-v4";
>   		reg = <0xf98a4900 0x11c>, <0xf98a4000 0x800>;
>   		interrupts = <0 125 0>;
>   		bus-width = <4>;